Skip to content

Conversation

@andrei-tyk
Copy link
Contributor

@andrei-tyk andrei-tyk commented Nov 18, 2025

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Ticket Details

TT-16142
Status Open
Summary High CVE's on 5.10.1 release

Generated at: 2025-11-18 09:19:48

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

🎯 Recommended Merge Targets

Based on JIRA ticket TT-16142: High CVE's on 5.10.1 release

Fix Version: Tyk 5.10.1

Required:

  • release-5.10.1 - Exact version branch for Tyk 5.10.1 - specific patch release
  • release-5.10 - Minor version branch for 5.10.x patches - required for creating Tyk 5.10.1
  • master - Main development branch - ensures fix is in all future releases

📋 Workflow

  1. Merge this PR to master first

  2. Cherry-pick to release branches by commenting on the merged PR:

    • /release to release-5.10.1
    • /release to release-5.10
  3. Automated backport - The bot will automatically create backport PRs to the specified release branches

@github-actions
Copy link
Contributor

🚨 Jira Linter Failed

Commit: b128724
Failed at: 2025-11-18 09:19:49 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to validate Jira issue: jira ticket TT-16142 has status 'Open' but must be one of: In Dev, In Code Review, Ready For Dev, Dod Check

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

@github-actions
Copy link
Contributor

API Changes

no api changes detected

@probelabs
Copy link

probelabs bot commented Nov 18, 2025

🔍 Code Analysis Results

PR Overview

This PR addresses security vulnerabilities (CVEs) by updating several Go dependencies in go.mod and go.sum.

Files Changed Analysis

  • go.mod & go.sum: Modified to update the versions of three dependencies.

Architecture & Impact Assessment

What this PR accomplishes:
This PR mitigates security risks by updating dependencies with known vulnerabilities.

Key technical changes introduced:

  • google.golang.org/protobuf was updated from v1.36.4 to v1.36.5.
  • github.com/dvsekhvalnov/jose2go was updated from v1.6.0 to v1.8.0 (indirect dependency).
  • github.com/opencontainers/runc was updated from v1.1.14 to v1.3.3 (indirect dependency).

Affected system components:

  • Co-Process Middleware (coprocess): The protobuf library is fundamental to the gRPC communication for custom middleware. This update patches the serialization layer.
  • Authentication/Authorization: The jose2go library is likely a transitive dependency for JWT handling. The update affects security aspects of token validation or signing.
  • Integration Test Environment: runc is a dependency of dockertest, which is used to spin up containers for testing. This change impacts only the test execution environment.
graph TD
    subgraph Test Environment
        Dockertest --> Runc[runc v1.3.3]
    end

    subgraph Application
        Coprocess[Coprocess gRPC] --> Protobuf[protobuf v1.36.5]
        Auth[Auth Layer] --> JWT_Lib[Some JWT Lib] --> Jose2Go[jose2go v1.8.0]
    end

    TykGateway[Tyk Gateway] --> Coprocess
    TykGateway --> Auth
Loading

Scope Discovery & Context Expansion

The scope of this change is limited to dependency updates and does not alter application logic directly. The primary impact is on the security and stability of components that rely on these libraries:

  • The protobuf update is crucial for the coprocess feature, which involves data serialization and communication with external processes.
  • The jose2go and runc updates are for indirect dependencies, reducing the likelihood of direct impact on the application's core logic but improving the security posture of the testing and authentication stacks.
Metadata
  • Review Effort: 2 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2025-11-18T09:22:14.433Z | Triggered by: opened | Commit: 0ae7d42

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link

probelabs bot commented Nov 18, 2025

🔍 Code Analysis Results

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.

Quality Issues (1)

Severity Location Issue
🟡 Warning go.mod:1
The pull request updates dependencies, reportedly to fix CVEs, but the description is empty. It fails to specify which vulnerabilities are being addressed. Additionally, the repository's own checklist item, 'I explained why this PR updates go.mod in detail with reasoning why it's required', is unchecked. This lack of context prevents a proper risk assessment of the dependency upgrades and hinders security auditing.
💡 SuggestionPlease update the pull request description to detail the specific CVEs that each dependency update resolves. This information is critical for maintainability and for creating a clear audit trail for security fixes.

✅ Dependency Check Passed

No dependency issues found – changes LGTM.

✅ Connectivity Check Passed

No connectivity issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2025-11-18T09:22:15.867Z | Triggered by: opened | Commit: 0ae7d42

💡 TIP: You can chat with Visor using /visor ask <your question>

@sonarqubecloud
Copy link

@ilijabojanovic ilijabojanovic self-requested a review November 18, 2025 09:56
@andrei-tyk andrei-tyk enabled auto-merge (squash) November 18, 2025 09:59
@andrei-tyk andrei-tyk merged commit b1e1142 into master Nov 18, 2025
48 of 49 checks passed
@andrei-tyk andrei-tyk deleted the TT-16142-high-cv-es-on-5-10-1-release branch November 18, 2025 10:12
@ilijabojanovic
Copy link
Member

/release to release-5.10.1

probelabs bot pushed a commit that referenced this pull request Nov 18, 2025
<!-- Provide a general summary of your changes in the Title above -->

## Description

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-16142" title="TT-16142"
target="_blank">TT-16142</a>
</summary>

|         |    |
|---------|----|
| Status  | Open |
| Summary | High CVE's on 5.10.1 release |

Generated at: 2025-11-18 09:19:48

</details>

<!---TykTechnologies/jira-linter ends here-->

(cherry picked from commit b1e1142)
@probelabs
Copy link

probelabs bot commented Nov 18, 2025

✅ Cherry-pick successful. A PR was created: #7545

@andrei-tyk
Copy link
Contributor Author

/release to release-5.10

@andrei-tyk
Copy link
Contributor Author

/release to release-5.8

probelabs bot pushed a commit that referenced this pull request Nov 18, 2025
<!-- Provide a general summary of your changes in the Title above -->

## Description

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-16142" title="TT-16142"
target="_blank">TT-16142</a>
</summary>

|         |    |
|---------|----|
| Status  | Open |
| Summary | High CVE's on 5.10.1 release |

Generated at: 2025-11-18 09:19:48

</details>

<!---TykTechnologies/jira-linter ends here-->

(cherry picked from commit b1e1142)
@probelabs
Copy link

probelabs bot commented Nov 18, 2025

✅ Cherry-pick successful. A PR was created: #7547

@probelabs
Copy link

probelabs bot commented Nov 18, 2025

⚠️ Cherry-pick encountered conflicts. A draft PR was created: #7548

andrei-tyk added a commit that referenced this pull request Nov 18, 2025
### **User description**
[TT-16142]  fix CVEs for v5.10.1 (#7543)

<!-- Provide a general summary of your changes in the Title above -->

## Description

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-16142" title="TT-16142"
target="_blank">TT-16142</a>
</summary>

|         |    |
|---------|----|
| Status  | Open |
| Summary | High CVE's on 5.10.1 release |

Generated at: 2025-11-18 09:19:48

</details>

<!---TykTechnologies/jira-linter ends here-->

[TT-16142]:
https://tyktech.atlassian.net/browse/TT-16142?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


___

### **PR Type**
Enhancement, Bug fix


___

### **Description**
- Bump `runc` to v1.3.3 to address CVEs

- Upgrade `jose2go` to v1.8.0 security release

- Update `protobuf` to v1.36.5 patch

- Refresh go.sum to match new versions


___

### Diagram Walkthrough


```mermaid
flowchart LR
  deps["Dependency versions"]
  runc["opencontainers/runc v1.1.14 -> v1.3.3"]
  jose["dvsekhvalnov/jose2go v1.6.0 -> v1.8.0"]
  proto["google.golang.org/protobuf v1.36.4 -> v1.36.5"]
  sum["go.sum updated"]

  deps -- "upgrade" --> runc
  deps -- "upgrade" --> jose
  deps -- "upgrade" --> proto
  runc -- "reflect in" --> sum
  jose -- "reflect in" --> sum
  proto -- "reflect in" --> sum
```



<details> <summary><h3> File Walkthrough</h3></summary>

<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>go.mod</strong><dd><code>Bump security-sensitive
dependencies in go.mod</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

go.mod

<ul><li>Upgrade <code>google.golang.org/protobuf</code> to v1.36.5.<br>
<li> Bump <code>github.com/dvsekhvalnov/jose2go</code> to v1.8.0
(indirect).<br> <li> Bump <code>github.com/opencontainers/runc</code> to
v1.3.3 (indirect).</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7547/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+3/-3</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>go.sum</strong><dd><code>Refresh go.sum for upgraded
dependencies</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

go.sum

<ul><li>Update checksums for <code>jose2go</code> v1.8.0.<br> <li>
Update checksums for <code>runc</code> v1.3.3.<br> <li> Update checksums
for <code>protobuf</code> v1.36.5.</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7547/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+6/-6</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>
</table></td></tr></tr></tbody></table>

</details>

___

Co-authored-by: andrei-tyk <97896463+andrei-tyk@users.noreply.github.com>
ilijabojanovic pushed a commit that referenced this pull request Nov 18, 2025
…7545)

### **User description**
[TT-16142]  fix CVEs for v5.10.1 (#7543)

<!-- Provide a general summary of your changes in the Title above -->

## Description

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-16142" title="TT-16142"
target="_blank">TT-16142</a>
</summary>

|         |    |
|---------|----|
| Status  | Open |
| Summary | High CVE's on 5.10.1 release |

Generated at: 2025-11-18 09:19:48

</details>

<!---TykTechnologies/jira-linter ends here-->

[TT-16142]:
https://tyktech.atlassian.net/browse/TT-16142?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


___

### **PR Type**
Enhancement, Bug fix


___

### **Description**
- Bump `runc` to v1.3.3 for CVEs

- Upgrade `jose2go` to v1.8.0

- Update `protobuf` to v1.36.5

- Refresh go.sum for new versions


___

### Diagram Walkthrough


```mermaid
flowchart LR
  deps["Dependencies (go.mod)"]
  runc["opencontainers/runc v1.3.3"]
  jose["dvsekhvalnov/jose2go v1.8.0"]
  proto["google.golang.org/protobuf v1.36.5"]
  gosum["go.sum updates"]

  deps -- "bump" --> runc
  deps -- "bump" --> jose
  deps -- "bump" --> proto
  runc -- "reflect in" --> gosum
  jose -- "reflect in" --> gosum
  proto -- "reflect in" --> gosum
```



<details> <summary><h3> File Walkthrough</h3></summary>

<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>go.mod</strong><dd><code>Dependency bumps addressing
security CVEs</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

go.mod

<ul><li>Update <code>google.golang.org/protobuf</code> to v1.36.5.<br>
<li> Upgrade <code>github.com/dvsekhvalnov/jose2go</code> to v1.8.0
(indirect).<br> <li> Bump <code>github.com/opencontainers/runc</code> to
v1.3.3 (indirect).</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7545/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+3/-3</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>go.sum</strong><dd><code>Checksum updates for bumped
dependencies</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

go.sum

<ul><li>Sync checksums for <code>jose2go</code> v1.8.0.<br> <li> Sync
checksums for <code>runc</code> v1.3.3.<br> <li> Sync checksums for
<code>protobuf</code> v1.36.5.</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7545/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+6/-6</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>
</table></td></tr></tr></tbody></table>

</details>

___

Co-authored-by: andrei-tyk <97896463+andrei-tyk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants