Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-14244: [release-5.3] Bump go, set godebug for compatibility #6913

Open
wants to merge 1 commit into
base: release-5.3
Choose a base branch
from

Conversation

titpetric
Copy link
Contributor

@titpetric titpetric commented Mar 2, 2025

User description

https://tyktech.atlassian.net/browse/TT-14244


PR Type

  • Enhancement

Description

  • Bump Go version to 1.23.6.

  • Add multiple godebug flags.

  • Enhance TLS and x509 debug compatibility.


Changes walkthrough 📝

Relevant files
Enhancement
go.mod
Upgrade Go version and insert godebug flags.                         

go.mod

  • Upgraded Go version from 1.23.4 to 1.23.6.
  • Added godebug flag for tls10server.
  • Added godebug flag for tls3des.
  • Added godebug flag for tlsrsakex.
  • Added godebug flag for tlsunsafeekm.
  • Added godebug flag for x509keypairleaf.
  • Added godebug flag for x509negativeserial.
  • +13/-1   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    github-actions bot commented Mar 2, 2025

    API Changes

    no api changes detected

    Copy link
    Contributor

    github-actions bot commented Mar 2, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Compatibility Check

    Confirm that the upgrade to Go 1.23.6 and the addition of multiple godebug flags do not conflict with existing dependency requirements or runtime compatibility.

    module github.com/TykTechnologies/tyk
    
    go 1.23.6
    
    godebug tls10server=1
    
    godebug tls3des=1
    
    godebug tlsrsakex=1
    
    godebug tlsunsafeekm=1
    
    godebug x509keypairleaf=0
    
    godebug x509negativeserial=1
    

    Copy link
    Contributor

    github-actions bot commented Mar 2, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Security
    Remove insecure TLS debug flags

    Review and remove or conditionally enable the insecure TLS debugging flags to
    prevent potential security vulnerabilities in production.

    go.mod [5-15]

    -godebug tls10server=1
    -godebug tls3des=1
    -godebug tlsrsakex=1
    -godebug tlsunsafeekm=1
    -godebug x509keypairleaf=0
    -godebug x509negativeserial=1
    +# Consider removing these flags or enabling them only for testing environments to enhance security.
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion rightly highlights potential production security issues by flagging insecure TLS debugging options, though it only provides a comment rather than a concrete code change.

    Medium

    @titpetric titpetric changed the title TT-14244: Bump go, set godebug for compatibility TT-14244: [release-5.3] Bump go, set godebug for compatibility Mar 2, 2025
    Copy link

    sonarqubecloud bot commented Mar 2, 2025

    Quality Gate Failed Quality Gate failed

    Failed conditions
    6 Security Hotspots
    75.0% Coverage on New Code (required ≥ 80%)

    See analysis details on SonarQube Cloud

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants