Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-4-lts: [TT-9284] Ensure that old transport will close idle connections (#5231) #5741

Commits on Nov 6, 2023

  1. [TT-9284] Ensure that old transport will close idle connections (#5231)

    <details open>
      <br />
      <table>
        <tr>
          <th>Summary</th>
    <td>[CS] The gateway leaks file handles via sockets when max_conn_time
    is above 0</td>
        </tr>
        <tr>
          <th>Type</th>
          <td>
    <img alt="Bug"
    src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium"
    />
            Bug
          </td>
        </tr>
        <tr>
          <th>Status</th>
          <td>In Code Review</td>
        </tr>
        <tr>
          <th>Points</th>
          <td>N/A</td>
        </tr>
      </table>
    </details>
    <!--
      do not remove this marker as it will break jira-lint's functionality.
      added_by_jira_lint
    -->
    
    ---
    
    TBD
    
    <!-- Describe your changes in detail -->
    
    <!-- This project only accepts pull requests related to open issues. -->
    <!-- If suggesting a new feature or change, please discuss it in an
    issue first. -->
    <!-- If fixing a bug, there should be an issue describing it with steps
    to reproduce. -->
    <!-- OSS: Please link to the issue here. Tyk: please create/link the
    JIRA ticket. -->
    
    <!-- Why is this change required? What problem does it solve? -->
    
    <!-- Please describe in detail how you tested your changes -->
    <!-- Include details of your testing environment, and the tests -->
    <!-- you ran to see how your change affects other areas of the code,
    etc. -->
    <!-- This information is helpful for reviewers and QA. -->
    
    <!-- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test
    coverage to functionality)
    
    <!-- Go over all the following points, and put an `x` in all the boxes
    that apply -->
    <!-- If there are no documentation updates required, mark the item as
    checked. -->
    <!-- Raise up any additional concerns not covered by the checklist. -->
    
    - [ ] I ensured that the documentation is up to date
    - [ ] I explained why this PR updates go.mod in detail with reasoning
    why it's required
    - [ ] I would like a code coverage CI quality gate exception and have
    explained why
    
    ---------
    
    Co-authored-by: Tit Petric <tit@tyk.io>
    
    (cherry picked from commit 3b1379e)
    buger authored and Tyk Bot committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5b8d1f5 View commit details
    Browse the repository at this point in the history
  2. Resolve conflicts

    Tit Petric committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    f963896 View commit details
    Browse the repository at this point in the history
  3. Set s.Gw to update Test.Gw

    Tit Petric committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2380434 View commit details
    Browse the repository at this point in the history
  4. Fix references to s.Gw/gw

    Tit Petric committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    62e510a View commit details
    Browse the repository at this point in the history