Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-10414] [release-4-lts] Fix python coprocess tests, pin protobuf dependency in CI #5737

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

titpetric
Copy link
Contributor

No description provided.

… to key reuse (#5720)

Co-authored-by: Tit Petric <tit@tyk.io>
Copy link

sweep-ai bot commented Nov 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@buger
Copy link
Member

buger commented Nov 6, 2023

API tests result: success
Branch used: refs/heads/release-4-lts
Commit: 4234213 Merging to release-4-lts: TT-8547 Fix websocket error proxying (#4918)

TT-8547 Fix websocket error proxying (#4918)

Description

Upgrade websocket only when server responded with 101.
Fixes the case when websocket have own authentification, so we can proxy
this error.

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why
    Triggered by: push (@buger)
    Execution page

@titpetric titpetric marked this pull request as draft November 6, 2023 10:06
@titpetric titpetric marked this pull request as ready for review November 6, 2023 10:12
@titpetric titpetric enabled auto-merge (squash) November 6, 2023 10:14
@titpetric titpetric merged commit 4ada3e5 into release-4-lts Nov 6, 2023
5 checks passed
@titpetric titpetric deleted the backport/tt-10414/fix-python-coprocess branch November 6, 2023 10:14
@buger
Copy link
Member

buger commented Nov 6, 2023

API tests result: success
Branch used: refs/pull/5737/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

@buger
Copy link
Member

buger commented Nov 6, 2023

API tests result: success
Branch used: refs/pull/5737/merge
Commit: 3848ccd
Triggered by: pull_request (@titpetric)
Execution page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants