Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-7414] Call ApplyPolicies after go plugin #5642

Merged
merged 2 commits into from
Oct 23, 2023
Merged

[TT-7414] Call ApplyPolicies after go plugin #5642

merged 2 commits into from
Oct 23, 2023

Conversation

furkansenharputlu
Copy link
Contributor

@furkansenharputlu furkansenharputlu commented Oct 18, 2023 •
edited
Loading

@furkansenharputlu furkansenharputlu self-assigned this Oct 18, 2023
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Oct 18, 2023
@furkansenharputlu furkansenharputlu force-pushed the fix/goplugin-apply-policy branch from 714fa8c to d928229 Compare October 18, 2023 17:04
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

API Changes

--- prev.txt	2023-10-22 10:58:42.932049409 +0000
+++ current.txt	2023-10-22 10:58:37.463999505 +0000
@@ -10595,6 +10595,7 @@
 func MyAnalyticsPluginDeleteHeader(record *analytics.AnalyticsRecord)
 func MyAnalyticsPluginMaskJSONLoginBody(record *analytics.AnalyticsRecord)
 func MyPluginAccessingOASAPI(rw http.ResponseWriter, r *http.Request)
+func MyPluginApplyingPolicy(rw http.ResponseWriter, r *http.Request)
 func MyPluginAuthCheck(rw http.ResponseWriter, r *http.Request)
     MyPluginAuthCheck does custom auth and will be used as "auth_check" custom
     MW

@buger
Copy link
Member

buger commented Oct 18, 2023

API tests result: success ✅
Branch used: refs/pull/5642/merge
Commit: d928229
Triggered by: pull_request (@furkansenharputlu)
Execution page

@buger
Copy link
Member

buger commented Oct 18, 2023

API tests result: success ✅
Branch used: refs/pull/5642/merge
Commit:
Triggered by: pull_request (@furkansenharputlu)
Execution page

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@buger
Copy link
Member

buger commented Oct 22, 2023

API tests result: success ✅
Branch used: refs/pull/5642/merge
Commit: 956a577
Triggered by: pull_request (@furkansenharputlu)
Execution page

@furkansenharputlu furkansenharputlu merged commit 1f110d8 into master Oct 23, 2023
@furkansenharputlu furkansenharputlu deleted the fix/goplugin-apply-policy branch October 23, 2023 12:11
@furkansenharputlu
Copy link
Contributor Author

/release to release-5.2

@furkansenharputlu
Copy link
Contributor Author

/release to release-5-lts

@tykbot
Copy link

tykbot bot commented Oct 23, 2023

Working on it! Note that it can take a few minutes.

1 similar comment
@tykbot
Copy link

tykbot bot commented Oct 23, 2023

Working on it! Note that it can take a few minutes.

@buger buger mentioned this pull request Oct 23, 2023
Merged
tykbot bot pushed a commit that referenced this pull request Oct 23, 2023
@furkansenharputlu
[TT-7414] Call ApplyPolicies after go plugin (#5642)
dd2a696 
Jira ticket: https://tyktech.atlassian.net/browse/TT-7414

(cherry picked from commit 1f110d8)
@tykbot
Copy link

tykbot bot commented Oct 23, 2023

@furkansenharputlu Succesfully merged PR

@tykbot
Copy link

tykbot bot commented Oct 23, 2023

Still working...

@buger buger mentioned this pull request Oct 23, 2023
Merged
tykbot bot pushed a commit that referenced this pull request Oct 23, 2023
@furkansenharputlu
[TT-7414] Call ApplyPolicies after go plugin (#5642)
b1dff3a 
Jira ticket: https://tyktech.atlassian.net/browse/TT-7414

(cherry picked from commit 1f110d8)
@tykbot
Copy link

tykbot bot commented Oct 23, 2023

@furkansenharputlu Succesfully merged PR

furkansenharputlu added a commit that referenced this pull request Oct 23, 2023
@buger @furkansenharputlu
Merging to release-5-lts: [TT-7414] Call ApplyPolicies after go plugin (
62328a5 
#5642) (#5663)

[TT-7414] Call ApplyPolicies after go plugin (#5642)

Jira ticket: https://tyktech.atlassian.net/browse/TT-7414

[TT-7414]:
https://tyktech.atlassian.net/browse/TT-7414?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Furkan Senharputlu <furkan_senharputlu@hotmail.com>
buger added a commit that referenced this pull request Oct 23, 2023
@buger
Merging to release-5.2: [TT-7414] Call ApplyPolicies after go plugin (#…
c9c0006 
…5642)

[TT-7414] Call ApplyPolicies after go plugin (#5642)

Jira ticket: https://tyktech.atlassian.net/browse/TT-7414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titpetric titpetric titpetric approved these changes

@jeffy-mathew jeffy-mathew Awaiting requested review from jeffy-mathew

Assignees

@furkansenharputlu furkansenharputlu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furkansenharputlu @buger @titpetric