Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-7489/TT-9576]refactor TestTransformResponseBody to res_handler_transform.go. #5352

Conversation

jeffy-mathew
Copy link
Contributor

@jeffy-mathew jeffy-mathew commented Jul 26, 2023

improve ResponseTransformMiddleware_Enabled.

Description

https://tyktech.atlassian.net/browse/TT-9576

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@jeffy-mathew jeffy-mathew force-pushed the chore/TT-7489/do-not-load-response-transform-middleware-when-disabled branch from eb7ae06 to edbcf5b Compare July 26, 2023 06:12
@jeffy-mathew jeffy-mathew force-pushed the chore/TT-7489/do-not-load-response-transform-middleware-when-disabled branch from edbcf5b to 9b8ad82 Compare July 26, 2023 06:20
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 26, 2023
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 26, 2023
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 26, 2023

API tests result: success
Branch used: refs/pull/5352/merge
Commit: edbcf5b
Triggered by: pull_request (@jeffy-mathew)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 26, 2023

API tests result: success
Branch used: refs/pull/5352/merge
Commit:
Triggered by: pull_request (@jeffy-mathew)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 26, 2023

API tests result: success
Branch used: refs/pull/5352/merge
Commit: 9b8ad82
Triggered by: pull_request (@jeffy-mathew)
Execution page

@jeffy-mathew jeffy-mathew force-pushed the chore/TT-7489/do-not-load-response-transform-middleware-when-disabled branch from 9b8ad82 to 98e9ca3 Compare July 26, 2023 09:45
@jeffy-mathew jeffy-mathew enabled auto-merge (squash) July 26, 2023 09:45
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jeffy-mathew jeffy-mathew merged commit 808df11 into master Jul 26, 2023
13 of 14 checks passed
@jeffy-mathew jeffy-mathew deleted the chore/TT-7489/do-not-load-response-transform-middleware-when-disabled branch July 26, 2023 09:59
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 26, 2023

API tests result: success
Branch used: refs/pull/5352/merge
Commit: 98e9ca3
Triggered by: pull_request (@jeffy-mathew)
Execution page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants