Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9551] Fix scope issues #5343

Closed
wants to merge 8 commits into from
Closed

[TT-9551] Fix scope issues #5343

wants to merge 8 commits into from

Conversation

titpetric
Copy link
Contributor

@titpetric titpetric commented Jul 22, 2023

Description

This addresses a few scope / compilation issues.

  • It removes a deprecated https://pkg.go.dev/golang.org/x/net/context
  • It aliases use of stdlib apis via internal packages (1 import from gw package, no fragmentation)
  • The coprocess_api.go imports C, put it behind a cgo build tag
  • Aliases use of text/template and html/template (scope differentiation, within the package scope both of those are named template, aliasing makes code non-conflicting on itself).
  • Fixes a test case to pass sonarcloud (asserting error return in test)

The deprecated context package is coming from the msgpack.v2 dependency (go mod why). Investigate bumping the dependency, or replacing it with an up to date one (out of scope).

Related Issue

https://tyktech.atlassian.net/browse/TT-9551

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 22, 2023
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 22, 2023
@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 22, 2023

API tests result: success
Branch used: refs/pull/5343/merge
Commit:
Triggered by: pull_request (@titpetric)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 22, 2023

API tests result: success
Branch used: refs/pull/5343/merge
Commit: 5d22c16
Triggered by: pull_request (@titpetric)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 22, 2023

API tests result: success
Branch used: refs/pull/5343/merge
Commit: 5c7e465
Triggered by: pull_request (@titpetric)
Execution page

@github-actions
Copy link
Contributor

💥 CI tests failed 🙈

git-state

all ok

Please look at the run or in the Checks tab.

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 22, 2023

API tests result: success
Branch used: refs/pull/5343/merge
Commit: b236c7f
Triggered by: pull_request (@titpetric)
Execution page

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 22, 2023

API tests result: success
Branch used: refs/pull/5343/merge
Commit: 6327fd7
Triggered by: pull_request (@titpetric)
Execution page

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Tyk-ITS
Copy link
Contributor

Tyk-ITS commented Jul 24, 2023

API tests result: success
Branch used: refs/pull/5343/merge
Commit: 67baf32
Triggered by: pull_request (@jeffy-mathew)
Execution page

jeffy-mathew
jeffy-mathew previously approved these changes Jul 24, 2023
@jeffy-mathew jeffy-mathew self-requested a review July 24, 2023 06:54
@jeffy-mathew jeffy-mathew dismissed their stale review July 24, 2023 07:12

missing jira ticket

@jeffy-mathew jeffy-mathew changed the title Fix scope issues [TT-9551] Fix scope issues Jul 24, 2023
@titpetric titpetric closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants