-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-9551] Fix scope issues #5343
Conversation
API tests result: success ✅ |
API tests result: success ✅ |
API tests result: success ✅ |
💥 CI tests failed 🙈git-stateall ok Please look at the run or in the Checks tab. |
API tests result: success ✅ |
API tests result: success ✅ |
6327fd7
to
67baf32
Compare
Kudos, SonarCloud Quality Gate passed! |
API tests result: success ✅ |
Description
This addresses a few scope / compilation issues.
coprocess_api.go
imports C, put it behind acgo
build tagtext/template
andhtml/template
(scope differentiation, within the package scope both of those are namedtemplate
, aliasing makes code non-conflicting on itself).The deprecated context package is coming from the msgpack.v2 dependency (go mod why). Investigate bumping the dependency, or replacing it with an up to date one (out of scope).
Related Issue
https://tyktech.atlassian.net/browse/TT-9551
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist