Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-1188 mdcb testing framework / Gw refactor #3438

Merged
merged 131 commits into from
Mar 25, 2021
Merged

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Jan 11, 2021

Description

refactor GW in order that we can run multiple instances as objects via code (not docker, not binaries), added method to run gw in testing mode as a worker node. Created gw object that wrapps some information and methods specific for a gateway instance. This must be merged in tandem with:

Related Issue

https://tyktech.atlassian.net/browse/TT-1188

Motivation and Context

Created the proper structure so we can run integration tests for MDCB environment

How This Has Been Tested

  • Run Gw
  • Run GW instances from MDCB testing framework

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sredxny sredxny changed the title Tt 1188 mdcb testing framework TT-1188 mdcb testing framework Jan 11, 2021
gateway/server.go Outdated Show resolved Hide resolved
gateway/server.go Outdated Show resolved Hide resolved
gateway/server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@matiasinsaurralde matiasinsaurralde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to fix the conflicts.

@sredxny sredxny changed the title TT-1188 mdcb testing framework TT-1188 mdcb testing framework {WIP} Feb 4, 2021
TESTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@padiazg padiazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tbuchaillot tbuchaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buger buger merged commit 8ef52cb into master Mar 25, 2021
@buger buger deleted the TT-1188-mdcb-testing-framework branch March 25, 2021 17:09
furkansenharputlu added a commit that referenced this pull request Mar 25, 2021
sredxny added a commit that referenced this pull request Mar 25, 2021
@sredxny sredxny restored the TT-1188-mdcb-testing-framework branch March 25, 2021 21:49
gregdelhon pushed a commit that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants