Policy REST API #3302
Merged
Policy REST API #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gernest
suggested changes
Sep 9, 2020
|
Thanks for the review @gernest. Have made suggested changes. |
gernest
suggested changes
Sep 9, 2020
vaske
force-pushed
the
policy-restapi
branch
from
bc2cbd6 to
2c607a1
Compare
buger
approved these changes
Sep 9, 2021
Co-authored-by: Geofrey Ernest <geofreyernest@live.com>
Fixes retrieving single policy
vaske
force-pushed
the
policy-restapi
branch
from
273f680 to
5716220
Compare
buger
reviewed
Sep 13, 2021
| @@ -85,7 +85,8 @@ type PoliciesConfig struct { | |||
| // If you set this value to `true`, then the id parameter in a stored policy (or imported policy using the Dashboard API), will be used instead of the internal ID. | |||
| // | |||
| // This option should only be used when moving an installation to a new database. | |||
| AllowExplicitPolicyID bool `json:"allow_explicit_policy_id"` | |||
| AllowExplicitPolicyID bool `json:"allow_explicit_policy_id"` | |||
| PolicyPath string `json:"policy_path"` | |||
There was a problem hiding this comment.
Do not forget adding a comment to all fields, since it will be used to auto-generate docs.
There was a problem hiding this comment.
Oh didn't know that, adding it
buger
approved these changes
Sep 13, 2021
gernest
approved these changes
Sep 14, 2021
vaske
added a commit
that referenced
this pull request
Jan 18, 2022
* REST API for policies * amend logs in policy loader * handler for path param * fix path load * resolve review issues * tests for handler and cleanup - actually add policy to map when creating * update mutex Co-authored-by: Geofrey Ernest <geofreyernest@live.com> * Fixed retrieving a single Policy (#3315) Fixes retrieving single policy * fixed issues after rebase * fixed test lint issues * ts.run checked * code cleanup * fixed schema model * fixed failing tests for policies * added comments for docs Co-authored-by: Geofrey Ernest <geofreyernest@live.com> Co-authored-by: Sedky Abou-Shamalah <sedkyaboushamalah@gmail.com> Co-authored-by: Milan Vasic <milan.vasic.su@gmail.com> # Conflicts: # gateway/api.go
|
merged manually to release-4-lts |
furkansenharputlu
added a commit
that referenced
this pull request
Mar 15, 2022
This reverts commit 75114d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a way to manage policies in Tyk CE using a REST API instead of the single file approach currently. It makes policies act in very much the same way as API when using CE. A directory is specified in the Tyk config in the new
policies.policy_pathfield. Policies are then stored in that folder with their ID as a filename i.e.default-policy.json. CRUD operations can be carried out by calling{GATEWAYHOST}:{PORT}/tyk/policiesendpoint with the policy ID passed in the last part of Path.Related Issue
Fixes #2379
Motivation and Context
Means simpler way of managing policies - also unblocks development of Kubernetes Operator for the OSS Gateway.
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet