-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP method to middleware request object #1386
Add HTTP method to middleware request object #1386
Conversation
I see you added the following comment:
But what about If so, what commands I should run to do that? |
return beta_implementations.dynamic_stub(channel, 'coprocess.Dispatcher', cardinalities, options=stub_options) | ||
except ImportError: | ||
pass | ||
import grpc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stuff is new, did you used some experimental protobuf version to build this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dispatcher
class looks mostly the same, theBetaDispatcher
changed a bit, I will investigate this (shouldn't affect).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it required grpc
packages (previously it dont).
I would say that it is better to run script with same protobuf version as we officially use now in CI.
5dd85c9
to
6d5fd0e
Compare
6d5fd0e
to
19e86c2
Compare
I've updated my Protocol Buffers setup to make sure that we're using the latest stable version, so the bindings have been generated using
I have also updated the instructions and the script that we use to generate the bindings to explicitly use Python 3 (previously it could mess things up if you ran the Python generator using "python" instead of "python3"). |
Both JSVM and Coprocess. In addition, fixed missing "certificate" field.
Both JSVM and Coprocess. In addition, fixed missing "certificate" field.
Both JSVM and Coprocess. In addition, fixed missing "certificate" field.
Both JSVM and Coprocess. In addition, fixed missing "certificate" field.
This covers both coprocess & JSVM, related to #1219.