-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: TykTechnologies/tyk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 273f680
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: TykTechnologies/tyk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5716220
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 14 commits
- 10 files changed
- 7 contributors
Commits on Sep 10, 2021
-
[TT-2216] Gmaiztegi signature param (#3662)
<!-- Provide a general summary of your changes in the Title above --> ## Description This PR adds `use_param` and `param` to the signature configuration, in order to be able to pass the signature as a query parameter (I would appreciate some help to know how to correctly document these new fields). These parameters behave very similar to those regarding the token. ## Related Issue #3511 ## Motivation and Context bde50bc added support for a Mashery-style signature validation, but it only supports getting the signature from a header. Mashery supports passing the signature in a query parameter, so it would be great to support this feature and mimic this behaviour. ## How This Has Been Tested I have to say I'm super new to the Golang community so I tested this only with the test added to this PR, so I would appreciate some feedback while I build the Docker image and test it inside Kubernetes. ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! --> - [X] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own fork, don't request your `master`! - [X] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start *your branch* off *our latest `master`*. - [X] My change requires a change to the documentation. - [X] If you've changed APIs, describe what needs to be updated in the documentation. - [ ] If new config option added, ensure that it can be set via ENV variable - [ ] I have updated the documentation accordingly. - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor` - [ ] When updating library version must provide reason/explanation for this update. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [X] Check your code additions will not fail linting checks: - [X] `go fmt -s` - [X] `go vet`
Configuration menu - View commit details
-
Copy full SHA for b187b3f - Browse repository at this point
Copy the full SHA b187b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84289db - Browse repository at this point
Copy the full SHA 84289dbView commit details
Commits on Sep 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d7a6ac9 - Browse repository at this point
Copy the full SHA d7a6ac9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 022b70b - Browse repository at this point
Copy the full SHA 022b70bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d680070 - Browse repository at this point
Copy the full SHA d680070View commit details -
Configuration menu - View commit details
-
Copy full SHA for b196f57 - Browse repository at this point
Copy the full SHA b196f57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b6b25d - Browse repository at this point
Copy the full SHA 8b6b25dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a167fe - Browse repository at this point
Copy the full SHA 9a167feView commit details -
Co-authored-by: Geofrey Ernest <geofreyernest@live.com>
Configuration menu - View commit details
-
Copy full SHA for 3d160ab - Browse repository at this point
Copy the full SHA 3d160abView commit details -
Fixed retrieving a single Policy (#3315)
Fixes retrieving single policy
Configuration menu - View commit details
-
Copy full SHA for 91ebca1 - Browse repository at this point
Copy the full SHA 91ebca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c19bb36 - Browse repository at this point
Copy the full SHA c19bb36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d73357 - Browse repository at this point
Copy the full SHA 3d73357View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe721a3 - Browse repository at this point
Copy the full SHA fe721a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5716220 - Browse repository at this point
Copy the full SHA 5716220View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 273f680...5716220