Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TykTechnologies/tyk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 273f680
Choose a base ref
...
head repository: TykTechnologies/tyk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5716220
Choose a head ref
  • 14 commits
  • 10 files changed
  • 7 contributors

Commits on Sep 10, 2021

  1. [TT-2216] Gmaiztegi signature param (#3662)

    <!-- Provide a general summary of your changes in the Title above -->
    
    ## Description
    This PR adds `use_param` and `param` to the signature configuration, in order to be able to pass the signature as a query parameter (I would appreciate some help to know how to correctly document these new fields). These parameters behave very similar to those regarding the token.
    
    ## Related Issue
    
    #3511
    
    ## Motivation and Context
    
    bde50bc added support for a Mashery-style signature validation, but it only supports getting the signature from a header. Mashery supports passing the signature in a query parameter, so it would be great to support this feature and mimic this behaviour.
    
    ## How This Has Been Tested
    
    I have to say I'm super new to the Golang community so I tested this only with the test added to this PR, so I would appreciate some feedback while I build the Docker image and test it inside Kubernetes.
    
    ## Screenshots (if appropriate)
    
    ## Types of changes
    <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
    - [ ] Bug fix (non-breaking change which fixes an issue)
    - [X] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing functionality to change)
    - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)
    
    ## Checklist
    <!-- Go over all the following points, and put an `x` in all the boxes that apply -->
    <!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
    - [X] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
          fork, don't request your `master`!
    - [X] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start
          *your branch* off *our latest `master`*.
    - [X] My change requires a change to the documentation.
      - [X] If you've changed APIs, describe what needs to be updated in the documentation.
      - [ ] If new config option added, ensure that it can be set via ENV variable
    - [ ] I have updated the documentation accordingly.
    - [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor`
    - [ ] When updating library version must provide reason/explanation for this update.
    - [ ] I have added tests to cover my changes.
    - [ ] All new and existing tests passed.
    - [X] Check your code additions will not fail linting checks:
      - [X] `go fmt -s`
      - [X] `go vet`
    furkansenharputlu authored Sep 10, 2021
    Configuration menu
    Copy the full SHA
    b187b3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84289db View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. REST API for policies

    joshblakeley authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    d7a6ac9 View commit details
    Browse the repository at this point in the history
  2. amend logs in policy loader

    joshblakeley authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    022b70b View commit details
    Browse the repository at this point in the history
  3. handler for path param

    joshblakeley authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    d680070 View commit details
    Browse the repository at this point in the history
  4. fix path load

    joshblakeley authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    b196f57 View commit details
    Browse the repository at this point in the history
  5. resolve review issues

    joshblakeley authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    8b6b25d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9a167fe View commit details
    Browse the repository at this point in the history
  7. update mutex

    Co-authored-by: Geofrey Ernest <geofreyernest@live.com>
    2 people authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    3d160ab View commit details
    Browse the repository at this point in the history
  8. Fixed retrieving a single Policy (#3315)

    Fixes retrieving single policy
    sedkis authored and vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    91ebca1 View commit details
    Browse the repository at this point in the history
  9. fixed issues after rebase

    vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    c19bb36 View commit details
    Browse the repository at this point in the history
  10. fixed test lint issues

    vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    3d73357 View commit details
    Browse the repository at this point in the history
  11. ts.run checked

    vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    fe721a3 View commit details
    Browse the repository at this point in the history
  12. code cleanup

    vaske committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    5716220 View commit details
    Browse the repository at this point in the history
Loading