Skip to content

Commit

Permalink
[TT-7488/TT-9594]modify json schema to allow both body and path if pr…
Browse files Browse the repository at this point in the history
…ovided (#5367)

<!-- Provide a general summary of your changes in the Title above -->

## Description

This PR modifies json schema to allow both path and body if provided
while creating a transform body (Request/Response) middleware.

## Related Issue
https://tyktech.atlassian.net/browse/TT-9594

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)
screenshot after saving the middleware changes
![Screenshot 2023-07-27 at 11 56 25
AM](https://github.com/TykTechnologies/tyk/assets/8171046/cdd0bf6b-eb71-4a50-b83f-f39e4a1394f2)

Raw editor
![Screenshot 2023-07-27 at 12 33 20
PM](https://github.com/TykTechnologies/tyk/assets/8171046/6217ff4d-7529-43d1-ba4b-14a4fc7a86a7)


## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why
  • Loading branch information
jeffy-mathew authored Jul 27, 2023
1 parent 2306137 commit 3c508e6
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions apidef/oas/schema/x-tyk-api-gateway.json
Original file line number Diff line number Diff line change
Expand Up @@ -546,22 +546,19 @@
"type": "string"
}
},
"oneOf": [
"anyOf": [
{
"required": [
"body"
]
"required": ["body"]
},
{
"required": [
"path"
]
"required": ["path"]
}
],
"required": [
"enabled",
"format"
]
],
"minProperties": 3
},
"X-Tyk-CachePlugin": {
"type": "object",
Expand Down

0 comments on commit 3c508e6

Please sign in to comment.