Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-8809 ContextWithSpan #22

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

kofoworola
Copy link
Contributor

@kofoworola kofoworola commented Jul 31, 2023

Description

THis change adds ContextWithSpan to the otel library for this PR

Related Issue

https://tyktech.atlassian.net/browse/TT-8809

Motivation and Context

https://tyktech.atlassian.net/browse/TT-8809

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • I have reviewed the guidelines for contributing to this repository.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kofoworola
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tbuchaillot tbuchaillot changed the title added context with span TT-8809 ContextWithSpan Jul 31, 2023
@tbuchaillot tbuchaillot self-requested a review July 31, 2023 10:36
@tbuchaillot tbuchaillot merged commit f40b74f into TykTechnologies:main Jul 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants