Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-8183 Resources #20

Merged
merged 4 commits into from
Jul 20, 2023
Merged

TT-8183 Resources #20

merged 4 commits into from
Jul 20, 2023

Conversation

tbuchaillot
Copy link
Collaborator

@tbuchaillot tbuchaillot commented Jul 19, 2023

Description

Adding resource constructors

Related Issue

https://tyktech.atlassian.net/browse/TT-8183

Motivation and Context

https://tyktech.atlassian.net/browse/TT-8183

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • I have reviewed the guidelines for contributing to this repository.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...

@tbuchaillot tbuchaillot changed the title Resources TT-8183 Resources Jul 19, 2023
Copy link
Contributor

@mativm02 mativm02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbuchaillot tbuchaillot merged commit 7d5b6dc into main Jul 20, 2023
4 checks passed
@tbuchaillot tbuchaillot deleted the feat/resources branch July 20, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants