-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kibisis): implement avm provider with kibisis client #175
Merged
drichar
merged 15 commits into
TxnLab:v3
from
agoralabs-sh:feat/kibisis-v3/implement-avm-provider-with-kibisis-client
Jun 8, 2024
Merged
feat(kibisis): implement avm provider with kibisis client #175
drichar
merged 15 commits into
TxnLab:v3
from
agoralabs-sh:feat/kibisis-v3/implement-avm-provider-with-kibisis-client
Jun 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 29, 2024
drichar
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. It's so much easier to grok now with @agoralabs-sh/avm-web-provider
handling the AVM logic. Thank you so much for your work on this!
drichar
changed the title
feat(kibisis v3): implement avm provider with kibisis client
feat(kibisis): implement avm provider with kibisis client
Jun 8, 2024
kieranroneill
deleted the
feat/kibisis-v3/implement-avm-provider-with-kibisis-client
branch
June 14, 2024 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kibisis now implements the AVM Web Provider and this is a complete overhaul of the Kibisis client to incorporate the AVM Web Provider.
Aside from replacing the
connect
andsignTransactions
functions, the Kibisis client now leverages thedisable
feature to correctly disconnect the Kibisis client. Thedisable
client communicates with the wallet and removes any saved sessions.This change also fixes the issue that is outlined in #148 in which groups of transactions were not correctly being signed.
Checklist