Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kibisis): implement avm provider with kibisis client #175

Conversation

kieranroneill
Copy link
Contributor

@kieranroneill kieranroneill commented May 29, 2024

Description

Please explain the changes you made here

Kibisis now implements the AVM Web Provider and this is a complete overhaul of the Kibisis client to incorporate the AVM Web Provider.

Aside from replacing the connect and signTransactions functions, the Kibisis client now leverages the disable feature to correctly disconnect the Kibisis client. The disable client communicates with the wallet and removes any saved sessions.

This change also fixes the issue that is outlined in #148 in which groups of transactions were not correctly being signed.

🚨 ALERT: this change is for the upcoming v3 of UseWallet

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@kieranroneill kieranroneill marked this pull request as ready for review June 5, 2024 09:12
Copy link
Collaborator

@drichar drichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It's so much easier to grok now with @agoralabs-sh/avm-web-provider handling the AVM logic. Thank you so much for your work on this!

@drichar drichar changed the title feat(kibisis v3): implement avm provider with kibisis client feat(kibisis): implement avm provider with kibisis client Jun 8, 2024
@drichar drichar merged commit 9a7203d into TxnLab:v3 Jun 8, 2024
1 check passed
@kieranroneill kieranroneill deleted the feat/kibisis-v3/implement-avm-provider-with-kibisis-client branch June 14, 2024 09:27
@drichar drichar added the v3 label Jun 20, 2024
@drichar drichar added this to the v3.0.0 stable release milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AVM Web Provider in UseWallet Cannot send more than 16 groups of groups of transactions
2 participants