Added support for RequireJS, CommonJS #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| define(['moment'], factory); | ||
| } else if ( typeof exports === 'object' ) { | ||
| // Node/CommonJS | ||
| module.exports = factory(); |
There was a problem hiding this comment.
Shouldn't you be doing factory(require('moment')) here? The moment-less build wont have moment bundled in, so moment will be undefined.
There was a problem hiding this comment.
Oops, I was focused on the AMD part and I missed that.
|
Thank you for making this. I had been wanting to add a UMD wrapper but hadn't gotten around to it. I think there's still some ways this could be cleaned up more, but this works for now. |
Twipped
added a commit
that referenced
this pull request
Feb 22, 2016
Added support for RequireJS, CommonJS
|
This is now released in version 0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.