Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support referencing TwingateGroup from TwingateResourceAccess #412

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Sep 23, 2024

Related Tickets & Documents

Changes

  • Added groupRef to TwingateResourceAccess CRD
  • Some improvement to integration test - when re-run from failed, the CI run number doesnt change which caused re-runs to not work. So added better randomization for resource names to allow rerunning

Usage Example:

apiVersion: twingate.com/v1beta
kind: TwingateResource
metadata:
  name: my-twingate-resource
spec:
  name: My K8S Resource
  address: my.default.cluster.local
  alias: mine.local
---
apiVersion: twingate.com/v1beta
kind: TwingateGroup
metadata:
  name: test-group
spec:
    name: Test Group
---
apiVersion: twingate.com/v1beta
kind: TwingateResourceAccess
metadata:
  name: my-twingate-resource
spec:
  resourceRef:
    name: my-twingate-resource
  groupRef:
    name: "test-group"

Copy link

linear bot commented Sep 23, 2024

@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11002532960

Details

  • 28 of 30 (93.33%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 94.846%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/crds.py 20 22 90.91%
Files with Coverage Reduction New Missed Lines %
app/crds.py 1 97.75%
Totals Coverage Status
Change from base Build 10999237471: -0.1%
Covered Lines: 975
Relevant Lines: 1014

💛 - Coveralls

@ekampf ekampf marked this pull request as ready for review September 23, 2024 21:32
Copy link
Contributor

@liorr liorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekampf ekampf merged commit c27f98f into main Sep 23, 2024
16 checks passed
@ekampf ekampf deleted the feature/oss-42-support-group-reference branch September 23, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants