Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor video controller #315

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Refactor video controller #315

merged 6 commits into from
Oct 22, 2021

Conversation

HuixingWong
Copy link
Contributor

No description provided.

@HuixingWong HuixingWong marked this pull request as ready for review October 21, 2021 06:09
JoeSteven
JoeSteven requested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@JoeSteven JoeSteven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this branch , works fine .But i was thinking would it be better to create a Real controller instead of exposing NativePlayerView? So that we can hide the code details of operating player into the controller.

JoeSteven
JoeSteven approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@JoeSteven JoeSteven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@probot-auto-merge probot-auto-merge bot merged commit a4c3f80 into feature/desktop Oct 22, 2021
@probot-auto-merge probot-auto-merge bot deleted the refactor-video-controller branch October 22, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeSteven JoeSteven JoeSteven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HuixingWong @JoeSteven