Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bold #3

Merged
merged 5 commits into from
Mar 9, 2021
Merged

Add bold #3

merged 5 commits into from
Mar 9, 2021

Conversation

kawsark
Copy link
Contributor

@kawsark kawsark commented Mar 8, 2021

Simple update

TwiN
TwiN requested changes Mar 9, 2021
View reviewed changes
Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've applied the two changes requested, please add Bold = "" in color_windows.go after line 17.

color.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@kawsark
Copy link
Contributor Author

kawsark commented Mar 9, 2021

Hello @TwinProduction - sounds good, please see my latest commit

@TwiN
Copy link
Owner

TwiN commented Mar 9, 2021

@kawsark you forgot to address the comment about color_windows.go above 😅

@kawsark
Copy link
Contributor Author

kawsark commented Mar 9, 2021

Oops I missed that @TwinProduction, please check now

@TwiN TwiN merged commit fc49f7b into TwiN:master Mar 9, 2021
@TwiN TwiN changed the title Added Orange and Bold colors Add bold Mar 9, 2021
@TwiN
Copy link
Owner

TwiN commented Mar 10, 2021

Thank you for your contribution!

Released in v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwiN TwiN TwiN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawsark @TwiN