Skip to content

Commit

Permalink
Add TLS 1.3 EXPORTER_SECRET to SSLKEYLOGFILE.
Browse files Browse the repository at this point in the history
Per discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1287711.
Otherwise this feature won't work for QUIC.

Change-Id: Ia799bfd1e29c01161c4298fb3124c96f62ada9c5
Reviewed-on: https://boringssl-review.googlesource.com/21104
Commit-Queue: Steven Valdez <svaldez@google.com>
Reviewed-by: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
  • Loading branch information
davidben authored and CQ bot account: commit-bot@chromium.org committed Oct 4, 2017
1 parent e7136a9 commit 1c58471
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ssl/tls13_enc.cc
Original file line number Diff line number Diff line change
@@ -236,7 +236,9 @@ int tls13_derive_application_secrets(SSL_HANDSHAKE *hs) {
hs->server_traffic_secret_0, hs->hash_len) &&
derive_secret(hs, ssl->s3->exporter_secret, hs->hash_len,
(const uint8_t *)kTLS13LabelExporter,
strlen(kTLS13LabelExporter));
strlen(kTLS13LabelExporter)) &&
ssl_log_secret(ssl, "EXPORTER_SECRET", ssl->s3->exporter_secret,
hs->hash_len);
}

static const char kTLS13LabelApplicationTraffic[] =

0 comments on commit 1c58471

Please sign in to comment.