Fix Floodgate prefix with ProtocolLib #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub permalinks can easily get longer than 120 characters.
Due to a bug in ProtocolLib, Floodgate will never execute some of its tasks if an async listener is registered. Related: GeyserMC/Floodgate#143 Skipped code: https://github.com/GeyserMC/Floodgate/blob/5d5713ed9e9eeab0f4abdaa9cf5cd8619dc1909b/spigot/src/main/java/org/geysermc/floodgate/addon/data/SpigotDataHandler.java#L121-L175 Fixes TuxCoding#786 Fixes TuxCoding#703 Fixes TuxCoding#689 Fixes TuxCoding#647
This reverts commit 9978fe6
Floodgate 2.0 has been released a long time ago.
13 tasks
TuxCoding
approved these changes
Aug 10, 2022
Owner
|
Sadly this solution is incompatible with ProtocoLib v4.8.0, which is necessary for below 1.18. |
Contributor
Author
|
Hopefully, I will just have to change some package/class names. Anyways, I won't be home until Sunday/Monday, so I can't check it now. If it causes too much trouble, then just revert it, or disable it for 1.18 and below with an if. |
Contributor
Author
|
I took a look at it from mobile, and playerInjectionHandler is just playerInjection in plib 4.8.0. code above that ran successfully, and playerInjectionHandler.getChannel() exists, so this could be an easy fix, although I still can't test it until I get home. You cna check it if the issue is urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your change
This was originally part of #709.
During the login start packet, the channel of the player is extracted from the ProtocolLIb handler, and if it contains a FloodgatePlayer attribute, we execute Floodgate's tasks manually, because ProtocolLib doesn't fire packets down the channel pipeline if it has an async listener attached to it.
Related issue
Fixes #786
Fixes #703
Fixes #689
Fixes #647