Skip to content

Conversation

@Smart123s
Copy link
Contributor

Summary of your change

If the pluign is running on Bukkit, and it's connected to Bungee
then core.getStorage() will be null.
If that's the case, players will be logged in via a plugin messages.

Related issue

#602 (comment)

If the pluign is running on Bukkit, and it's connected to Bungee
then core.getStorage() will be null.
If that's the case, players will be logged in via a plugin messages.
@Smart123s
Copy link
Contributor Author

Auto registering still didn't work for me, even when I used the commits from this PR.

I've noticed that the following line returned false:

https://github.com/games647/FastLogin/blob/7c125dc0b6d2a6904977d93e35b2673b7cef97ce/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/BungeeListener.java#L107

If I had removed the if checking below that, then I was able to auto register:

https://github.com/games647/FastLogin/blob/7c125dc0b6d2a6904977d93e35b2673b7cef97ce/bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/BungeeListener.java#L109-L112

I don't fully understand what it does, so I don't want to touch it. Would it be safe to remove it for Floodgate players?

@TuxCoding
Copy link
Owner

It was necessary to add, because in Paper the Bungee message fires before the PlayerJoinEvent. However then the player isn't ready yet. So we have to detect which event fires later.

@Smart123s
Copy link
Contributor Author

Ok, thanks for explaining, now I understand it. But where does the auto login/register happen if result is false?

@TuxCoding
Copy link
Owner

TuxCoding commented Aug 28, 2021

@TuxCoding TuxCoding added the bug Something isn't working label Aug 28, 2021
@Smart123s
Copy link
Contributor Author

I get it now, thanks. Although it seems like #606 (comment) was also fixed by #608.

@TuxCoding TuxCoding merged commit d802193 into TuxCoding:main Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants