This repository was archived by the owner on May 1, 2025. It is now read-only.
toBoolean and toNumber change. #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to use:
var qs = new MongoQS({
string: {
toNumber: false
}
});
But toNumber and toBoolean is always in true.
I propose a change so firstly it checks if it is boolean and then makes the change.
Thanks for this great module! :)
Starefossen
suggested changes
May 29, 2017
index.js
Outdated
| this.string.toBoolean = opts.string.toBoolean || true; | ||
| this.string.toNumber = opts.string.toNumber || true; | ||
| this.string.toBoolean = (typeof(opts.string.toBoolean) === "boolean") ? opts.string.toBoolean : true; | ||
| this.string.toNumber = (typeof(opts.string.toNumber) === "boolean") ? opts.string.toNumber : true; |
There was a problem hiding this comment.
Could you remove the ( and ) after typeof to make the tests passing?
|
Thansk a lot @lucaskenda 💯 I have added you a as collaborator for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use:
var qs = new MongoQS({
string: {
toNumber: false
}
});
But toNumber and toBoolean is always in true.
I propose a change so firstly it checks if it is boolean and then makes the change.
Thanks for this great module! :)