Skip to content

bump versions, update AD tests, update workflows #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 18, 2025
Merged

bump versions, update AD tests, update workflows #166

merged 14 commits into from
Jun 18, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Jun 15, 2025

This fixes all the existing CompatHelper PRs

Closes #160
Closes #161
Closes #163
Closes #164

And also updates the AD testing to use Mooncake (and removes the previously commented-out Tracker and Zygote tests).

And also updates the test and format workflows to more closely match the rest of TuringLang. In particular:

  • uses TuringLang/actions/Format for workflow standardisation
  • tests on both Julia 1.10 and Julia 1.11
  • removes the arch=x64 matrix variable which is no longer appropriate for macOS-latest (should be aarch64, but leaving it out is easier as it will allow GitHub to automatically determine the right architecture)

@penelopeysm penelopeysm changed the title bump versions, update AD tests bump versions, update AD tests, update workflows Jun 15, 2025
Copy link
Contributor

TuringGLM.jl documentation for PR #166 is available at:
https://TuringLang.github.io/TuringGLM.jl/previews/PR166/

penelopeysm and others added 3 commits June 18, 2025 10:17
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ce483e4

Some non-blocking comments.

strategy:
fail-fast: false
matrix:
version:
- '1.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is '1.10' covered by '1'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh LTS is 1.10 and 1 is 1.11 gotcha.

README.md Outdated
Comment on lines 6 to 7
[![Coverage](https://codecov.io/gh/TuringLang/TuringGLM.jl/branch/main/graph/badge.svg)](https://codecov.io/gh/TuringLang/TuringGLM.jl)
[![Coverage](https://coveralls.io/repos/github/TuringLang/TuringGLM.jl/badge.svg?branch=main)](https://coveralls.io/github/TuringLang/TuringGLM.jl?branch=main)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not using these badges anymore in TuringLang org repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Turing.jl still has the coverage badges, but coverage isn't enabled for TuringGLM (https://github.com/TuringLang/TuringGLM.jl/blob/main/.github/workflows/CI.yml) so AFAIK this is not being updated (the badges currently displayed in the main readme has codecov @ 74% pointing to a commit from a while ago, and coveralls says unknown).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not blocking, but you can try to re-enable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, let me try to copy the config over from another repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works you can add the badges back

@penelopeysm
Copy link
Member Author

Ok I think the badges should update themselves once this is merged :)

@penelopeysm penelopeysm merged commit 73775d7 into main Jun 18, 2025
9 of 10 checks passed
@penelopeysm penelopeysm deleted the py/bumps branch June 18, 2025 15:02
@storopoli
Copy link
Member

Nice, thanks!

@storopoli
Copy link
Member

We need to tag a new version.

@penelopeysm
Copy link
Member Author

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants