-
Notifications
You must be signed in to change notification settings - Fork 8
bump versions, update AD tests, update workflows #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TuringGLM.jl documentation for PR #166 is available at: |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ce483e4
Some non-blocking comments.
strategy: | ||
fail-fast: false | ||
matrix: | ||
version: | ||
- '1.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is '1.10' covered by '1'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh LTS is 1.10 and 1
is 1.11
gotcha.
README.md
Outdated
[](https://codecov.io/gh/TuringLang/TuringGLM.jl) | ||
[](https://coveralls.io/github/TuringLang/TuringGLM.jl?branch=main) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not using these badges anymore in TuringLang
org repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Turing.jl still has the coverage badges, but coverage isn't enabled for TuringGLM (https://github.com/TuringLang/TuringGLM.jl/blob/main/.github/workflows/CI.yml) so AFAIK this is not being updated (the badges currently displayed in the main readme has codecov @ 74% pointing to a commit from a while ago, and coveralls says unknown).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not blocking, but you can try to re-enable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, let me try to copy the config over from another repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works you can add the badges back
Ok I think the badges should update themselves once this is merged :) |
Nice, thanks! |
We need to tag a new version. |
Will do |
This fixes all the existing CompatHelper PRs
Closes #160
Closes #161
Closes #163
Closes #164
And also updates the AD testing to use Mooncake (and removes the previously commented-out Tracker and Zygote tests).
And also updates the test and format workflows to more closely match the rest of TuringLang. In particular:
arch=x64
matrix variable which is no longer appropriate for macOS-latest (should beaarch64
, but leaving it out is easier as it will allow GitHub to automatically determine the right architecture)