Add Aqua to tests #2257
Merged
Add Aqua to tests #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhauru
force-pushed
the
mhauru/code-formatting
branch
from
a27bbd7 to
16e5ab7
Compare
yebai
approved these changes
Jun 6, 2024
devmotion
reviewed
Jun 6, 2024
Comment on lines
+6
to
+8
| # TODO(mhauru) We skip testing for method ambiguities because it catches a lot of problems | ||
| # in dependencies. Would like to check it for just Turing.jl itself though. | ||
| Aqua.test_all(Turing; ambiguities=false) |
There was a problem hiding this comment.
If you want to test ambiguities, I suggest
Suggested change
| # TODO(mhauru) We skip testing for method ambiguities because it catches a lot of problems | |
| # in dependencies. Would like to check it for just Turing.jl itself though. | |
| Aqua.test_all(Turing; ambiguities=false) | |
| @testset "Aqua" begin | |
| # Test ambiguities separately without Base and Core | |
| # Ref: https://github.com/JuliaTesting/Aqua.jl/issues/77 | |
| Aqua.test_all(Turing; ambiguities = false) | |
| Aqua.test_ambiguities(Turing) | |
| end |
There was a problem hiding this comment.
Nice, thanks. I'll see if I can fix all the ambiguities, and if yes then commit this.
There was a problem hiding this comment.
I won't get to this today, and next week I'm off this project, so I'll merge what's here now and open an issue to come back to method ambiguities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out Aqua.jl and it caught some issues worth fixing, so I fixed them and made Aqua run as part of the test suite. Had to disable the method ambiguity checks though, because it was catching a lot of ambiguities not caused by us, but rather by our dependencies.
Ping @willtebbutt since he might be interested.