CompatHelper: bump compat for ADTypes to 1, (keep existing compat) #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2024-04-20-00-24-39-856-03977648508
branch
from
b983949
to
af867d1
Compare
torfjelde
previously approved these changes
Apr 20, 2024
|
Probably need to bump in DPPL, etc. first, no? Tests will be using old version I believe |
Pull Request Test Coverage Report for Build 8839150395Details
💛 - Coveralls |
|
Yes, currently some dependencies don't support ADTypes 1.0. I started with tpapp/LogDensityProblemsAD.jl#28 |
…39-856-03977648508
|
Seems some (test?) dependency holds it back: https://github.com/TuringLang/Turing.jl/actions/runs/8839150395/job/24271862153?pr=2200#step:6:79 |
|
Shite. It's AdvancedVI.jl... |
|
Double shite. I thought we were on AdvanceVI.jl 0.1..... 🤦 |
|
Attempt number 2: TuringLang/AdvancedVI.jl#56 |
torfjelde
deleted the
compathelper/new_version/2024-04-20-00-24-39-856-03977648508
branch
|
Shite. Didn't mean to merge this 🤦 |
torfjelde
restored the
compathelper/new_version/2024-04-20-00-24-39-856-03977648508
branch
torfjelde
deleted the
compathelper/new_version/2024-04-20-00-24-39-856-03977648508
branch
|
Once TuringLang/AdvancedVI.jl#56 goes through and is released, I'll make a new PR for this. Thought I was looking at another PR and saw all the green lights so hit merge.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
ADTypespackage from0.2to0.2, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.