-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InferenceObjects as a chain_type #1913
Conversation
Also, the |
It seems Edit: Ah, this is because Edit2: Ah, but when sampling e.g. with |
Pull Request Test Coverage Report for Build 5708532201Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1913 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1452 1483 +31
======================================
- Misses 1452 1483 +31
☔ View full report in Codecov by Sentry. |
For demonstration purposes, I've coded up a more complete example of what I mean at https://github.com/sethaxen/DynamicPPLInferenceObjects.jl |
It might be reasonable to convert this into an extension that weakly depends on It's a useful functionality, in my view. I am happy to merge this PR quickly. |
Ah, this has evolved substantially since this PR. TuringLang/DynamicPPL.jl#465 supersedes this PR by adding an InferenceObjects extension to DynamicPPL. That was held up by trying to get I do think that work can be done fairly quickly, but I need to wrap up a few things first before resuming. |
Closed in favour of TuringLang/DynamicPPL.jl#465 |
This PR is a prototype of adding
InferenceObjects.InferenceData
as achain_type
forsample
. Here's a working example:Note that all of this is type piracy, and it would probably be much cleaner to move this code into a DynamicPPLInferenceObjects.jl glue package that Turing instead depends on. However, we currently need the
metadata
function in order to retrieve sampling statistics andlogevidence
. Is there any way that functionality could be moved to DynamicPPL?Relates TuringLang/MCMCChains.jl#381