Skip to content

Fixing test timeouts #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fixing test timeouts #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2982c0e
dont test non-AD samplers for every AD backend
torfjelde Jul 16, 2021
63c1ec0
added back a test
torfjelde Jul 17, 2021
0f3ec25
added back a test
torfjelde Jul 17, 2021
31018c7
removed some redundant tests and fixed a typo
torfjelde Jul 17, 2021
fc87e42
added macro timed_testset
torfjelde Jul 17, 2021
65e735c
upper-bound Distributions.jl apparently fixes the test-freeze
torfjelde Jul 17, 2021
fec5e1b
hyphen compat specifies arent compatible with Julia 1.3
torfjelde Jul 17, 2021
604e3e2
removed the timed_testset stuff
torfjelde Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ AdvancedPS = "0.2"
AdvancedVI = "0.1"
Clustering = "0.14"
CmdStan = "6.0.8"
Distributions = "0.23.8, 0.24, 0.25"
Distributions = "< 0.25.11"
DistributionsAD = "0.6.3"
DynamicHMC = "2.1.6, 3.0"
DynamicPPL = "0.12"
Expand Down
2 changes: 1 addition & 1 deletion test/inference/Inference.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@testset "io.jl" begin
@testset "inference.jl" begin
# Only test threading if 1.3+.
if VERSION > v"1.2"
@testset "threaded sampling" begin
Expand Down
9 changes: 0 additions & 9 deletions test/inference/gibbs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,10 @@
chain = sample(gdemo(1.5, 2.0), alg, 5_000)
check_numerical(chain, [:s, :m], [49/24, 7/6], atol=0.1)

setadsafe(true)

Random.seed!(200)
gibbs = Gibbs(PG(15, :z1, :z2, :z3, :z4), HMC(0.15, 3, :mu1, :mu2))
chain = sample(MoGtest_default, gibbs, 5_000)
check_MoGtest_default(chain, atol=0.15)

setadsafe(false)

Random.seed!(200)
gibbs = Gibbs(PG(15, :z1, :z2, :z3, :z4), ESS(:mu1), ESS(:mu2))
chain = sample(MoGtest_default, gibbs, 5_000)
check_MoGtest_default(chain, atol=0.1)
end

@turing_testset "transitions" begin
Expand Down
20 changes: 15 additions & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,22 +46,27 @@ include("test_utils/AllUtils.jl")
include("core/ad.jl")
end

@testset "samplers (without AD)" begin
include("inference/AdvancedSMC.jl")
include("inference/emcee.jl")
include("inference/ess.jl")
include("inference/is.jl")
end

Turing.setrdcache(false)
for adbackend in (:forwarddiff, :tracker, :reversediff)
Turing.setadbackend(adbackend)
@info "Testing $(adbackend)"
start = time()
@testset "inference: $adbackend" begin
@testset "samplers" begin
include("inference/gibbs.jl")
include("inference/gibbs_conditional.jl")
include("inference/hmc.jl")
include("inference/is.jl")
include("inference/mh.jl")
include("inference/ess.jl")
include("inference/emcee.jl")
include("inference/AdvancedSMC.jl")
include("inference/Inference.jl")
include("contrib/inference/dynamichmc.jl")
include("contrib/inference/sghmc.jl")
include("inference/mh.jl")
end
end

Expand All @@ -72,6 +77,11 @@ include("test_utils/AllUtils.jl")
@testset "modes" begin
include("modes/ModeEstimation.jl")
end

# Useful for
# a) discovering performance regressions,
# b) figuring out why CI is timing out.
@info "Tests for $(adbackend) took $(time() - start) seconds"
end
@testset "variational optimisers" begin
include("variational/optimisers.jl")
Expand Down