Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Uniform -> Rejection #71

Merged
merged 3 commits into from
Nov 19, 2021
Merged

rename Uniform -> Rejection #71

merged 3 commits into from
Nov 19, 2021

Conversation

mileslucas
Copy link
Collaborator

I wanted to rename Uniform -> Rejection in the Proposals module because I think it is a better name. Despite this repo being pre-v1.0, I'll deprecate the Uniform constructor since I'm making a superficial change.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #71 (bee2568) into main (6b09bb7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bee2568 differs from pull request most recent head b965e1b. Consider uploading reports for the commit b965e1b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          12       12           
  Lines         531      531           
=======================================
  Hits          480      480           
  Misses         51       51           
Impacted Files Coverage Δ
src/proposals/Proposals.jl 93.29% <100.00%> (ø)
src/staticsampler.jl 100.00% <100.00%> (ø)
src/step.jl 94.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b09bb7...b965e1b. Read the comment docs.

@mileslucas mileslucas merged commit b901e03 into main Nov 19, 2021
@mileslucas mileslucas deleted the ml/rename branch November 19, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant