-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean MCMCChains, remove type piracy, and do not invalidate methods in Base #175
Conversation
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage ? 70.58%
=========================================
Files ? 17
Lines ? 1081
Branches ? 0
=========================================
Hits ? 763
Misses ? 318
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I've got no comments on this.
Nice job David! Much cleaner. Haven't checked all my examples yet but until now no surprises! |
This PR tries to clean and improve MCMCChains quite drastically. It removes two dependencies (Showoff and KernelDensity) which do not seem to be used anywhere in the package. Moreover, it fixes some severe issues with type piracy and invalidating methods in Base (exactly as Tim Holy suspected in the discourse thread, it seems), so hopefully this improves #171 as well (there is a similar issue in AbstractMCMC as well IMO).