Clean MCMCChains, remove type piracy, and do not invalidate methods in Base #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage ? 70.58%
=========================================
Files ? 17
Lines ? 1081
Branches ? 0
=========================================
Hits ? 763
Misses ? 318
Partials ? 0
Continue to review full report at Codecov.
|
cpfiffer
approved these changes
Feb 14, 2020
|
Nice job David! Much cleaner. Haven't checked all my examples yet but until now no surprises! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to clean and improve MCMCChains quite drastically. It removes two dependencies (Showoff and KernelDensity) which do not seem to be used anywhere in the package. Moreover, it fixes some severe issues with type piracy and invalidating methods in Base (exactly as Tim Holy suspected in the discourse thread, it seems), so hopefully this improves #171 as well (there is a similar issue in AbstractMCMC as well IMO).