-
Notifications
You must be signed in to change notification settings - Fork 10
Closed
Description
Was looking at
Libtask.jl/src/tapedfunction.jl
Line 65 in 5ec9f2b
cache_key = (f, args_type...) |
Shouldn't it be something like this instead ?
cache_key = (f, deepcopy_types, args_type...)
Otherwise this is giving counterintuitive results:
struct Dummy
a::Array
end
function f(d::Dummy)
produce(d.a)
end
d = Dummy([1])
t = TapedTask(f, d) # No Dummy in deepcopy_types
t2 = TapedTask(f, d; deepcopy_types=Dummy) # Dummy won't be part of the deepcopy_types
Metadata
Metadata
Assignees
Labels
No labels