Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add init_params keyword argument #26

Merged
merged 10 commits into from
Jan 19, 2022
Merged

Add init_params keyword argument #26

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
248fdad
Update abstractmcmc.jl
theogf Jan 18, 2022
7ab8331
Update interface.jl
theogf Jan 18, 2022
daa3b11
Update src/interface.jl
theogf Jan 18, 2022
aaf68f7
Modified proposal and added basic tests
theogf Jan 19, 2022
b7947b4
Update src/abstractmcmc.jl
theogf Jan 19, 2022
9485349
Correct typos
theogf Jan 19, 2022
debc01d
Mentionned keyword argument in docs, patch bump and test fix
theogf Jan 19, 2022
c281d90
Update test/simple.jl
theogf Jan 19, 2022
7fe49a6
Fix tests
devmotion Jan 19, 2022
ff5f188
Apply suggestions from code review
devmotion Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/abstractmcmc.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function AbstractMCMC.step(
rng::Random.AbstractRNG, model::AbstractMCMC.AbstractModel, ::ESS; kwargs...
theogf marked this conversation as resolved.
Show resolved Hide resolved
)
# initial sample from the Gaussian prior
f = initial_sample(rng, model)
f = initial_sample(rng, model; kwargs...)
theogf marked this conversation as resolved.
Show resolved Hide resolved

# compute log-likelihood of the initial sample
loglikelihood = Distributions.loglikelihood(model, f)
Expand Down
2 changes: 1 addition & 1 deletion src/interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Return the initial sample for the `model` using the random number generator `rng

By default, sample from [`prior(model)`](@ref).
"""
function initial_sample(rng::Random.AbstractRNG, model::AbstractMCMC.AbstractModel)
function initial_sample(rng::Random.AbstractRNG, model::AbstractMCMC.AbstractModel; kwargs...)
theogf marked this conversation as resolved.
Show resolved Hide resolved
return Random.rand(rng, prior(model))
end

Expand Down