Fix the incorrect Libtask bound #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @devmotion ! |
|
Can we start to use bors in the Turing repos? I've never used it myself but I've seen it so many times that we reintroduced removed code or broke something just because PRs were merged in some order. |
|
How does bors help with that? |
|
It would have detected that the Libtask PR fails after merging the other PR. |
|
It was fine on master at the time when it was opened but it was broken after the changes in the ThreadSafeVarInfo PR. As far as I understood, bors would run the test with the current master before actually merging it. |
|
Cool, let's give that a shot! |
|
As I said, I haven't used it myself but if I guess it would be helpful in particular when there are multiple PRs at the same time. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect bound.