Skip to content

Conversation

@devmotion
Copy link
Member

Fixes test error with Libtask 0.4 (the changes have to be added to Turing as well and maybe be extended, it's mainly to avoid introducing a bound on Libtask in DynamicPPL).

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files          13       13           
  Lines         853      853           
=======================================
  Hits          661      661           
  Misses        192      192           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180458e...b3450d3. Read the comment docs.

@mohamed82008 mohamed82008 merged commit 24a8c45 into master May 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the libtask branch May 2, 2020 18:41
@mohamed82008
Copy link
Contributor

Thanks @devmotion !

@devmotion
Copy link
Member Author

devmotion commented May 2, 2020

You shouldn't have merged this (at least not after the other PR). Now the tests of DynamicPPL are broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants