Skip to content

Conversation

@cpfiffer
Copy link
Member

I noticed there wasn't a minimum or maximum implementation for NoDist, so I added them.

@devmotion
Copy link
Member

Out of curiosity, what's the main purpose of NoDist?

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #88 into master will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   77.01%   76.83%   -0.19%     
==========================================
  Files          13       13              
  Lines         844      846       +2     
==========================================
  Hits          650      650              
- Misses        194      196       +2     
Impacted Files Coverage Δ
src/distribution_wrappers.jl 26.66% <0.00%> (-4.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06aa6a6...a75855f. Read the comment docs.

@devmotion
Copy link
Member

The PR looks good, maybe we could add a test?

@yebai yebai merged commit 83f8f98 into master Apr 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the csp/minmax branch April 28, 2020 20:39
@yebai
Copy link
Member

yebai commented Apr 28, 2020

The PR looks good, maybe we could add a test?

sorry, I merged too soon - maybe add a test in a separate PR?

@cpfiffer cpfiffer mentioned this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants