Make logp concretely typed by default and respect types in resetlogp!
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 13 13
Lines 845 845
=======================================
Hits 650 650
Misses 195 195
Continue to review full report at Codecov.
|
yebai
approved these changes
Apr 27, 2020
mohamed82008
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
This PR stops UntypedVarInfo from being usable with AD. Currently, this is not an issue since we always convert to TypedVarInfo but UntypedVarInfo is the only VarInfo usable when when some new variable symbols get sampled in a stochastic control flow. I have no problem merging this now though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on TuringLang/Turing.jl#1242, I noticed that initially
getlogp(vi)(whereviwas initialized asVarInfo()) returned0.0but subsequently after callingresetlogp!(vi)it actually returned0. The reason is two-fold: first,vi.logpis initialized as a reference to a Real number if not specified explicitly, and thenresetlogp!is implemented asresetlogp!(vi) = (vi.logp[] = 0)which does not perform any conversion to floating point numbers in this case.I changed both the initialization and
resetlogp!. I assume there were reasons for not concretely typevi.logpas default (maybe because of AD?) - however, all tests of Turing passed locally with this PR.