Revert to using setval_and_resample! in generated_quantities

[torfjelde]

As seen in #702 , generated_quantities currently does not work as intented for models with dot-tilde in it. This is due to changes made in #555 to generated_quantities, where we started using fix instead of setval_and_resample!.

Ideally, we should be using fix for this, so the changes introduces in #555 were completely reasonable. However, fix is still somewhat lacking in support; specifically, it lacks support for .~, as outlined in #702. This PR reverts these changes as a hotfix for the resulting bugs.

@mhauru

[coveralls]

Pull Request Test Coverage Report for Build 11667880187

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• 15 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.3%) to 77.536%

---

Files with Coverage Reduction	New Missed Lines	%
src/model.jl	1	92.47%
src/threadsafe.jl	14	48.6%

Totals
Change from base Build 11618965820:	-0.3%
Covered Lines:	3027
Relevant Lines:	3904

---

💛 - Coveralls

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (99def88) to head (5b63b09).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   77.73%   77.87%   +0.13%     
==========================================
  Files          30       30              
  Lines        3926     3909      -17     
==========================================
- Hits         3052     3044       -8     
+ Misses        874      865       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mhauru]

I'm surprised that VarNamedVector tests don't fail. Maybe they just don't hit the extension code. Anyway, I don't understand the new (old) code fully, but given that it's just reverting to previous (successful) behaviour, I'm happy to merge.

[torfjelde]

Might be worth considering #710 before we merge this

[yebai]

@sunxd3 can you help review this PR since it might relate to #651?

[penelopeysm]

The green tick is a relief :D, but I think we should definitely focus on #710 instead of this, as that fixes the same tests but in a better way.

[sunxd3]

The chain of PRs all make sense to me, sorry I couldn't give an in-depth review now, but I think Penny has a really good hold on the issue here. But definitely let me know if another serious look is required.

[torfjelde]

I'm increasingly in favour of just merging this and make a patch release. generated_quantities is currently broken (and have been for almost a week or so now), and this PR will provide a hotfix 😕

It's becoming clear that #710 requires quite a bit more effort: #710 (comment)

[mhauru]

Happy with that.

[penelopeysm]

Looking through test failures. At least one is a regression in Mooncake (chalk-lab/Mooncake.jl#345). Not sure if any of them are really DPPL-related.

[torfjelde]

Thanks for finding that @penelopeysm ! 👏

[penelopeysm]

Can confirm that all of the errors are purely Mooncake related, so will merge manually:)