[WIP] Use reserved names and allow interpolation #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs some discussion and is not ready to merge yet.
It contains a fix for #62 (only quickly tested in the REPL with
@macroexpandyet) and removes the different@sampler,@vietc macros by instead using reserved names for the arguments that user can access in their function definition, called_varinfo,_model,_sampler,_context. So basically users can do whatever they want but to avoid weird bugs and surprises for users a warning is displayed if these names appear in the model definition.I'm not sure yet if this is a reasonable or in any way better than the current macro based approach, I just wasn't completely satisfied with the macros since they require the use of brackets and look a bit ugly IMO. So I guess one might want to separate the first change in a separate PR.