Split up tilde functions based on usage #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 80.20% 80.22% +0.01%
==========================================
Files 12 12
Lines 864 900 +36
==========================================
+ Hits 693 722 +29
- Misses 171 178 +7
Continue to review full report at Codecov.
|
mohamed82008
reviewed
Apr 2, 2020
devmotion
reviewed
Apr 3, 2020
devmotion
reviewed
Apr 3, 2020
devmotion
reviewed
Apr 3, 2020
devmotion
approved these changes
Apr 3, 2020
|
Thanks @phipsgabler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements what I proposed in #46. Each
tildeordot_tildecall becomes(dot)_tilde_{assume,observe}, respectively, depending on position. And particularly, the varname and indices are also passed in for observations of non-literals.These additional arguments are just ignored by default, which makes the changes backwards-compatible.
Additionally, I changed the way assume/observed is distinguished by the
@preprocessmacro, which is now@isassumptionand does return a boolean. Thus the dispatch on tuple types becomes unnecessary.