Skip to content

Conversation

@devmotion
Copy link
Member

Should we drop, e.g., Julia 1.1?

@cpfiffer
Copy link
Member

Yeah, I think 1.1-1.2 can be dropped everywhere in TuringLang, and we should drop 1.3 in a month or two.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #52 into master will decrease coverage by 0.67%.
The diff coverage is 90.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   80.90%   80.23%   -0.68%     
==========================================
  Files          12       12              
  Lines         880      865      -15     
==========================================
- Hits          712      694      -18     
- Misses        168      171       +3     
Impacted Files Coverage Δ
src/DynamicPPL.jl 100.00% <ø> (ø)
src/contexts.jl 83.33% <ø> (ø)
src/model.jl 80.95% <80.95%> (-9.96%) ⬇️
src/prob_macro.jl 92.45% <92.15%> (-0.28%) ⬇️
src/compiler.jl 93.50% <100.00%> (-0.78%) ⬇️
src/utils.jl 41.02% <100.00%> (+8.67%) ⬆️
src/varinfo.jl 87.61% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08561a6...7bd082e. Read the comment docs.

@devmotion
Copy link
Member Author

The error still exists on Julia 1.4, it's just that the stable release of Julia on Travis has not been updated to 1.4 yet, so tests run on Julia 1.3 instead (see travis-ci/travis-build#1878).

@devmotion
Copy link
Member Author

IMO that would be the most reasonable test setup: Julia 1.0 LTS, Julia 1 stable, and Julia master.

@mohamed82008
Copy link
Contributor

Will close and re-open.

@devmotion
Copy link
Member Author

The bugfix release of Libtask is not available yet (TuringLang/Libtask.jl#57), so I'm sure the test will fail again.

@devmotion devmotion merged commit 61c4825 into master Apr 2, 2020
@devmotion devmotion deleted the devmotion-patch-1 branch April 2, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants