- 
                Notifications
    
You must be signed in to change notification settings  - Fork 37
 
          [Merged by Bors] - Extend docstring of @addlogprob!
          #389
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
leafcontextis not exported and may change. So this example might be fragile. In the future, wt would be better to avoid calling these low-level internal APIs to just get the current (primitive)context. But this should be addressed in separate PRs.cc @rikhuijzer you might want to take a look at how context works in
DynamicPPL.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was not super happy about bringing up
leafcontexthere - the purpose of the macro is to ensure that users don't have to use internal variable names and functions, so this is really not in line with our goals. Maybe we should just add a warning that it's always accumulated and one has to work with internal unstable fumctionality if that's not OK?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is okay to keep the example - it is useful for the users, but add a (big) warning that this interface is internal, and may change in the future.
A side note: we would like to improve the
contextdesign, together with themodelmacro implementation, in the longer term. Hopefully, these improvements will remove the requirement of usingleafcontext.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another alternative (or addition) would be separate macro (or a switch?) if the manual log probability corresponds to an observe statement. (One could also add something for assume statements explicitly, but I guess it is less common since then one also should add a sample to the varinfo - so maybe the observe behaviour should be the default?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not feel critical to have multiple versions of
@addlogprob!for now. Most people only use it insideMHorHMCsamplers. But there is a need, we can add support for that later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mainly concerned about the, in most cases, incorrect results of
logpriorcurrently - which is the main reason for this annoyingleafcontextapproach. I think this could be fixed by identifying it with a custom observe statement instead of an arbitrary modification of the log probability. One could eg. change the macro syntax toThen it would still be possible to unconditionally modify the log probability but one could also limit it easily to evaluations that include the likelihood or the prior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in any case this is out of scope for this PR, I think.