Extra context constructors #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tryBuild failed: |
devmotion
reviewed
Feb 15, 2022
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sure! |
|
bors try |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@ParadaCarleton With bors we don't have to test every single commit but can wait until the format is correct and (usually) until the design of the PR is approved. |
devmotion
requested changes
Feb 15, 2022
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
devmotion
reviewed
Feb 15, 2022
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tryBuild failed: |
added 2 commits
February 16, 2022 08:51
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
devmotion
reviewed
Feb 16, 2022
yebai
approved these changes
Feb 16, 2022
devmotion
reviewed
Feb 16, 2022
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
cool; should I merge @devmotion ? |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
Timed out. |
|
All the tests passed - it's unclear why |
|
thanks @ParadaCarleton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.