Skip to content

Conversation

@torfjelde
Copy link
Member

See related discussion: TuringLang/Turing.jl#1726 (comment).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@torfjelde
Copy link
Member Author

Does this seem good? Up for chosing a different name too.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something more explicit like use_threadsafe_eval or use_evaluate_threadsafe? Otherwise looks good to me.

@torfjelde
Copy link
Member Author

I like it! Done 👍

@torfjelde
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 15, 2021
@bors
Copy link
Contributor

bors bot commented Dec 15, 2021

Build failed:

@devmotion
Copy link
Member

Ref: julia-actions/setup-julia#91

@torfjelde
Copy link
Member Author

It's back!

@torfjelde
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 15, 2021
@bors
Copy link
Contributor

bors bot commented Dec 15, 2021

@bors bors bot changed the title Add requires_threadsafe [Merged by Bors] - Add requires_threadsafe Dec 15, 2021
@bors bors bot closed this Dec 15, 2021
@bors bors bot deleted the tor/threadsafe-improvement branch December 15, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants