Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2021

This pull request changes the compat entry for the Turing package from 0.18 to 0.18, 0.19 for package turing.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2021-11-03-00-05-35-344-02461841766 branch from b819d78 to 2eb1b88 Compare November 3, 2021 00:05
@yebai
Copy link
Member

yebai commented Nov 4, 2021

Bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

👎 Rejected by too few approved reviews

@devmotion
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 4, 2021
…p existing compat) (#335)

This pull request changes the compat entry for the `Turing` package from `0.18` to `0.18, 0.19` for package turing.
This keeps the compat entries for earlier versions.



Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@devmotion
Copy link
Member

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 5, 2021

Canceled.

@devmotion
Copy link
Member

This can't be tested properly currently since Turing is not compatible with DynamicPPL 0.16: https://github.com/TuringLang/Turing.jl/blob/d1d4071b603d60d6ba969f3b14bfb347795644b7/Project.toml#L49

@yebai
Copy link
Member

yebai commented Nov 5, 2021

This can't be tested properly currently since Turing is not compatible with DynamicPPL 0.16: https://github.com/TuringLang/Turing.jl/blob/d1d4071b603d60d6ba969f3b14bfb347795644b7/Project.toml#L49

@torfjelde Are you aware of what's missing from Turing to support DynamicPPL 0.16?

@yebai yebai merged commit 12f3b36 into master Dec 11, 2021
@yebai yebai deleted the compathelper/new_version/2021-11-03-00-05-35-344-02461841766 branch December 11, 2021 09:46
@yebai
Copy link
Member

yebai commented Dec 11, 2021

Fixed by new Turing release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants