[Merged by Bors] - Fix Zygote issue with dot_observe
#236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
commented
Apr 27, 2021
torfjelde
approved these changes
Apr 27, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
This PR fixes TuringLang/Turing.jl#1595. It is an alternative to #235 that does not require us to rewrite the primal less efficiently which would affect regular execution and other AD backends. Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
bors
bot
changed the title
dot_observedot_observe
torfjelde
reviewed
Sep 9, 2021
Comment on lines
+23
to
+26
| function dot_observe_fallback(spl, dists, value, vi) | ||
| increment_num_produce!(vi) | ||
| return sum(map(Distributions.loglikelihood, dists, value)) | ||
| end |
There was a problem hiding this comment.
I was just making some changes to #309 and noticed the adjoint introduced here. Isn't this wrong? If dists = [Normal()] and value = [1.0, 2.0], then we'd end up with sum([loglikelihood(Normal(), 1.0)]), right? 😕
There was a problem hiding this comment.
I agree, but at least back then this case was not supported by the primal definition so it did not seem to be necessary to consider it here: https://github.com/TuringLang/DynamicPPL.jl/pull/235/files
It seems the primal definition was removed/changed though, maybe it's not even needed anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes TuringLang/Turing.jl#1595.
It is an alternative to #235 that does not require us to rewrite the primal less efficiently which would affect regular execution and other AD backends.