Skip to content

Conversation

@torfjelde
Copy link
Member

Added a small test that would have caught #131 .

@yebai
Copy link
Member

yebai commented Jun 15, 2020

thanks, @torfjelde --- looks good to me. The failing test seems related to TuringLang/DistributionsAD.jl#84

@yebai
Copy link
Member

yebai commented Jun 15, 2020

@devmotion Not sure whether we should merge this into master or dev?

@devmotion
Copy link
Member

I guess it would be best to try to merge all PRs into dev since otherwise we might end up with different features in both branches and/or merge conflicts.

@yebai
Copy link
Member

yebai commented Jun 15, 2020

Sounds good. @torfjelde can you open a new PR against the dev branch instead?

@devmotion
Copy link
Member

I think the merge target can be changed in this PR actually.

@devmotion devmotion changed the base branch from master to dev June 15, 2020 21:43
@yebai yebai merged commit 700ae06 into dev Jun 15, 2020
@bors bors bot deleted the tor/context-tests branch June 15, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants