Skip to content

[breaking] v0.41#1286

Draft
penelopeysm wants to merge 4 commits intomainfrom
breaking
Draft

[breaking] v0.41#1286
penelopeysm wants to merge 4 commits intomainfrom
breaking

Conversation

@penelopeysm
Copy link
Member

No description provided.

@penelopeysm penelopeysm marked this pull request as draft February 24, 2026 20:25
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.70%. Comparing base (cca6402) to head (840c5d7).

Files with missing lines Patch % Lines
src/test_utils/ad.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   78.63%   78.70%   +0.06%     
==========================================
  Files          49       49              
  Lines        3492     3484       -8     
==========================================
- Hits         2746     2742       -4     
+ Misses        746      742       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Benchmark Report

  • this PR's head: 840c5d7d9c595c07f84e893c1f49e2d9d41cdfec
  • base branch: cca6402b74713f2a43274cc4f918dc7b8267ed2f

Computer Information

Julia Version 1.11.9
Commit 53a02c0720c (2026-02-06 00:27 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬────────┬───────────────────────────────┬────────────────────────────┬─────────────────────────────────┐
│                       │       │             │        │       t(eval) / t(ref)        │     t(grad) / t(eval)      │        t(grad) / t(ref)         │
│                       │       │             │        │ ─────────┬──────────┬──────── │ ───────┬─────────┬──────── │ ──────────┬───────────┬──────── │
│                 Model │   Dim │  AD Backend │ Linked │     base │  this PR │ speedup │   base │ this PR │ speedup │      base │   this PR │ speedup │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│               Dynamic │    10 │    mooncake │   true │   272.08 │   273.18 │    1.00 │   8.36 │   10.42 │    0.80 │   2274.28 │   2847.26 │    0.80 │
│                   LDA │    12 │ reversediff │   true │  2613.12 │  2648.69 │    0.99 │   3.80 │    3.94 │    0.96 │   9928.96 │  10441.83 │    0.95 │
│   Loop univariate 10k │ 10000 │    mooncake │   true │ 29983.20 │ 29904.82 │    1.00 │   6.32 │    6.47 │    0.98 │ 189548.57 │ 193476.57 │    0.98 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│    Loop univariate 1k │  1000 │    mooncake │   true │  3048.69 │  3054.58 │    1.00 │   6.78 │    6.26 │    1.08 │  20661.39 │  19133.32 │    1.08 │
│      Multivariate 10k │ 10000 │    mooncake │   true │ 30920.55 │ 30058.92 │    1.03 │  10.18 │   10.05 │    1.01 │ 314707.69 │ 302034.62 │    1.04 │
│       Multivariate 1k │  1000 │    mooncake │   true │  3301.02 │  3120.68 │    1.06 │   9.37 │    9.82 │    0.95 │  30922.14 │  30630.32 │    1.01 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│ Simple assume observe │     1 │ forwarddiff │  false │     0.84 │     0.85 │    1.00 │  10.44 │   10.32 │    1.01 │      8.82 │      8.73 │    1.01 │
│           Smorgasbord │   201 │ forwarddiff │  false │   933.75 │   930.60 │    1.00 │  71.61 │   72.61 │    0.99 │  66866.83 │  67572.68 │    0.99 │
│           Smorgasbord │   201 │      enzyme │   true │  1255.60 │  1240.37 │    1.01 │   6.43 │    4.86 │    1.32 │   8078.01 │   6034.17 │    1.34 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │   true │  1254.16 │  1249.90 │    1.00 │  69.51 │   70.96 │    0.98 │  87180.46 │  88696.87 │    0.98 │
│           Smorgasbord │   201 │    mooncake │   true │  1259.97 │  1292.14 │    0.98 │   4.60 │    4.51 │    1.02 │   5795.17 │   5824.11 │    1.00 │
│           Smorgasbord │   201 │ reversediff │   true │  1245.53 │  1248.03 │    1.00 │ 127.08 │  126.15 │    1.01 │ 158275.43 │ 157444.26 │    1.01 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│              Submodel │     1 │    mooncake │   true │     0.84 │     0.93 │    0.91 │  26.89 │   25.35 │    1.06 │     22.70 │     23.60 │    0.96 │
└───────────────────────┴───────┴─────────────┴────────┴──────────┴──────────┴─────────┴────────┴─────────┴─────────┴───────────┴───────────┴─────────┘

Closes #1309 

Simplifies `run_ad` by removing the `varinfo` keyword and using a single
`transform_strategy` path. Also replaces the `varinfo` field in
`ADResult` with `ldf::LogDensityFunction` and removes unused imports.

### Migration note

Before: `run_ad(model, adtype; varinfo=linked_vi)`
After: `run_ad(model, adtype; transform_strategy=LinkAll())`

---------

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

DynamicPPL.jl documentation for PR #1286 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1286/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants