Allow islinked for SampleFromPrior #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebai
reviewed
May 22, 2020
|
|
||
| """ | ||
| islinked(vi::VarInfo, spl::Sampler) | ||
| islinked(vi::VarInfo, spl::Union{Sampler, SampleFromPrior}) |
There was a problem hiding this comment.
It is a bit surprising that SampleFromPrior is not a subtype of Samper, but it is not a fault of this PR and can probably be fixed in the future.
There was a problem hiding this comment.
Maybe one could even just define this function for AbstractSampler.
There was a problem hiding this comment.
I'm hesitant to do that because you might have subtypes of AbstractSampler that don't fit this paradigm, and you'd have some weird errors. I'd prefer to be explicit for when these functions are permitted for various functions in DynamicPPL (i.e. when spl is not a Sampler).
yebai
approved these changes
May 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
islinked(vi, SampleFromPrior())isn't allowed due to type constraints. Does this seem like a reasonable fix?