Use non-global RNGs #120
Merged
Use non-global RNGs #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 74.83% 74.75% -0.09%
==========================================
Files 14 14
Lines 906 907 +1
==========================================
Hits 678 678
- Misses 228 229 +1
Continue to review full report at Codecov.
|
|
Turing is updated (with additional tests) in https://github.com/devmotion/Turing.jl/tree/rng, all tests pass locally. |
|
I think this is good to go, I noticed that the compiler docs in Turing are completely outdated (most parts are incorrect currently), so I don't think it's useful to just add a section about RNGs. |
mohamed82008
approved these changes
May 18, 2020
Co-authored-by: Mohamed Tarek <mohamed82008@gmail.com>
mohamed82008
approved these changes
May 20, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes TuringLang/Turing.jl#1260.
TODO:
- [ ] Fix documentation