Don't use closure for enzyme #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 82.41% 82.39% -0.03%
==========================================
Files 39 39
Lines 3964 3965 +1
==========================================
Hits 3267 3267
- Misses 697 698 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 17981527989Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@wsmoses Is there a particular motivation for avoiding closures? I benchmarked Enzyme on the demo models before / after this PR and I don't think there's a significant difference. Benchmarking code: using DynamicPPL, Distributions, Enzyme, ADTypes, DataFrames, CSV
using DynamicPPL.TestUtils.AD: run_ad, ADResult, NoTest
# For this PR I removed `function_annotation`
ADTYPES = Dict(
"EnzymeForward" => AutoEnzyme(; mode=set_runtime_activity(Forward, true), function_annotation=Const),
"EnzymeReverse" => AutoEnzyme(; mode=set_runtime_activity(Reverse, true), function_annotation=Const),
)
MODELS = DynamicPPL.TestUtils.DEMO_MODELS
RESULTS = []
for model in MODELS
for (adtype_name, adtype) in ADTYPES
result = run_ad(model, adtype; test=NoTest(), benchmark=true)
time_vs_primal = result.grad_time / result.primal_time
push!(RESULTS, (model="$(model.f)", adtype=adtype_name, time=time_vs_primal))
end
end
RESULT_DF = DataFrame(RESULTS)
CSV.write("results.csv", RESULT_DF) |
|
It makes it more natively compatible (eg no need for function annotation), which comes with plenty of benefits including a partial prereq for reactant compatibility |
|
Okay, I'll bump a patch and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.